Attention is currently required from: Martin Roth, Saurabh Mishra, Subrata Banik.

View Change

3 comments:

• Commit Message:

  • Patch Set #14, Line 7: src/include: Introducing a new SET_32_BIT_FLAG(x) macro.

    Remove the . at the end of line.

  • Patch Set #14, Line 9: This new macro addition ensures the shift operation does not

    This is a generic macro. Please describe the macro here.

    For example "This commit introduces the SET_32_BIT_FLAG macro, which generates a 32-bit mask with a specified bit set."

    In subsequent lines, the GEN_PMCON_A context is explained in detail.

  • Patch Set #14, Line 12:

    On a 64-bit system, 1ul will typically be 64 bits wide.
    The left shift can accommodate values of x up to 63 without overflowing.
    But `GEN_PMCON_A` register width is 32-bit hence, adding new SET_32_BIT_FLAG(x)
    to limit the register to max 32-bit width.
    

    is this > 72 ?

    yes

To view, visit change 84142. To unsubscribe, or for help writing mail filters, visit settings.