Attention is currently required from: Shelley Chen, Felix Singer, Tim Wawrzynczak, Paul Menzel, Angel Pons, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60784 )
Change subject: mb/google/herobrine: Initialize `pins` to fix the compilation issue
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Can we get this merge sooner, jenkin is complaining for every build. we need to fix this brokenness sooner.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60784
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I084fec777b56f402efb3b04a1d358cd5b0891846
Gerrit-Change-Number: 60784
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 08:08:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment