This change is ready for review.
6 comments:
Patch Set #8, Line 93: const char *path = "\\_SB_.TPM";
use acpi_device_path() […]
Ack
Patch Set #8, Line 111: acpigen_write_mem32fixed(1, TPM_CRB_BASE_ADDRESS, 0x5000);
TPM_CRB_BASE_ADDRESS can be read from *dev
What is the point here in NOT using the define?
Patch Set #8, Line 48: control_area.request = read32(CRB_REG(current_locality, CRB_REG_REQUEST));
all those lines are quite long. […]
Ack
Patch Set #8, Line 109: return -1;
use break here?
removed the unreachable return - though this should be fine.
Patch Set #8, Line 113: return -1;
unreachable
Ack
Patch Set #8, Line 230: // Write to Command Buffer
c++ comments are mixed with C89 comments
So?
To view, visit change 34106. To unsubscribe, or for help writing mail filters, visit settings.