12 comments:
File Documentation/mainboard/51nb/x210.jpg:
Maybe crop this image a bit, so that it is under 50 KiB?
Done
File Documentation/mainboard/51nb/x210.md:
Patch Set #33, Line 48: Use libgfxinit once Kaby Lake is supported.
Done, I guess?
Done
File src/mainboard/51nb/x210/acpi_tables.c:
This file shouldn't be needed anymore
Done
File src/mainboard/51nb/x210/devicetree.cb:
Patch Set #33, Line 167: register "PcieRpHotPlug[3]" = "1"
Hmmmmm... […]
Done
Patch Set #33, Line 179: webcam
Please capitalize: `Webcam`
Done
File src/mainboard/51nb/x210/dsdt.asl:
Patch Set #33, Line 33: // CPU
This comment does not add much value. […]
same as every other SKL/KBL board though
Patch Set #33, Line 46: // Chipset specific sleep states
This comment was dropped not too long ago
Done
File src/mainboard/51nb/x210/hda_verb.c:
Patch Set #33, Line 22: 0x0000000c
12
Done
Patch Set #33, Line 34: 0x17aa2155
This value in the comment might rot away.
Done
0 here and on AZALIA_PIN_CFG macros
Done
Patch Set #33, Line 39: /* Pin Complex (NID 0x19) */
I would drop these as they don't add much info.
ideally someone would add which pin is what, as with other boards
File src/mainboard/51nb/x210/romstage.c:
Patch Set #33, Line 31: sizeof(RcompResistor));
Fits on the previous line
Done
To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.