I'd suggest adding a #define PM_PDWN_Config 0x4cb0 and then using that constant in the code instead of the magic offset

View Change

1 comment:

To view, visit change 22260. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic42f2ff3e719636be67b00fa37155939cd2e17de
Gerrit-Change-Number: 22260
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Sat, 28 Apr 2018 19:56:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No