1 comment:
File src/southbridge/intel/i82801gx/sata.c:
Patch Set #5, Line 75: ret = ahci_supported && config->sata_no_ahci;
I don't see a reason to have this option
Without this option, the `else if (config->ide_legacy_combined)`
below would be unreachable on boards that support AHCI. I wouldn't
mind to remove combined mode altogether. But as long as we maintain
it, we should provide reasonable devicetree options.
IMHO, it should be an `enum sata_mode { ahci, ide, legacy, legacy_
combined };`. Unless we'd ditch combined mode. Then we could also
unify the sata code with everything up to BDW.
To view, visit change 30822. To unsubscribe, or for help writing mail filters, visit settings.