10 comments:
Patch Set #1, Line 7: Kconfig: Make CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM dependent on ARCH_RAMSTAGE_X86_32
why? That's not detailed here. […]
Ack
Patch Set #4, Line 7: Set default value
if we don't have ramstage enable then does it make sense to have a config (CACHE_RELOCATED_RAMSTAGE_ […]
Ack
Patch Set #3, Line 281: config CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM
i will add default here then
Ack
Patch Set #3, Line 1214: ARCH_X86
true, so far only x86 platform has selected this config
Ack
Patch Set #7, Line 252: default n if !ENABLE_STAGE_RAMSTAGE
can you please look at newer patchset, i have put explicit dependency from soc select
Ack
Patch Set #21, Line 259: config USE_EXTERNAL_STAGE_CACHE
I would call this simply 'TSEG_STAGE_CACHE' if that reflects accurately what we currently have.
Ack
Patch Set #21, Line 265: romstage
no, we have to exclude romstage
Ack
Patch Set #21, Line 268: config USE_CBMEM_STAGE_CACHE
Just 'CBMEM_STAGE_CACHE'. At least I find the prefix 'USE_' just useless.
Ack
Patch Set #22, Line 270: !NO_STAGE_CACHE
Got it, Aaron if you have little time today, can you please help to look into this CL https://review […]
Ack
File src/cpu/intel/smm/gen1/smmrelocate.c:
Patch Set #21, Line 124: if (CONFIG(USE_EXTERNAL_STAGE_CACHE)) {
yes, true. So are you suggesting to call it TSEG_STAGE_CACHE rather calling […]
Ack
To view, visit change 33116. To unsubscribe, or for help writing mail filters, visit settings.