199 comments:
File src/mainboard/asus/a88xm-e/BiosCallOuts.c:
that open brace { should be on the previous line
that open brace { should be on the previous line
Patch Set #5, Line 80: {0x10ec0887, (CODEC_ENTRY*)&a88xm_e_alc887_VerbTbl[0]},
"(foo*)" should be "(foo *)"
Patch Set #5, Line 81: {(UINT32)0x0FFFFFFFF, (CODEC_ENTRY*)0x0FFFFFFFFUL}
"(foo*)" should be "(foo *)"
File src/mainboard/asus/a88xm-e/OemCustomize.c:
Patch Set #5, Line 161: NUMBER_OF_DIMMS_SUPPORTED(ANY_SOCKET, ANY_CHANNEL, 1),
please, no spaces at the start of a line
Patch Set #5, Line 162: NUMBER_OF_CHANNELS_SUPPORTED(ANY_SOCKET, 2),
please, no spaces at the start of a line
Patch Set #5, Line 164: PSO_END
please, no spaces at the start of a line
Patch Set #5, Line 170: InitPost->MemConfig.PlatformMemoryConfiguration = (PSO_ENTRY *) MemoryTable_XM_E;
line over 96 characters
File src/mainboard/asus/a88xm-e/buildOpts.c:
Patch Set #5, Line 142: #define BLDCFG_PCIE_REFCLK_SPREAD_SPECTRUM 36 // PCIE Spread Spectrum default value 0.36%
line over 96 characters
Patch Set #5, Line 159: //#define BLDCFG_VRM_NB_LOW_POWER_THRESHOLD 1 // Zero - disable NBPSI_L, Non-zero - enable NBPSI_L
line over 96 characters
Patch Set #5, Line 160: //#define BLDCFG_VRM_NB_SLEW_RATE 5000 // Used in calculating the VSRampSlamTime
line over 96 characters
Patch Set #5, Line 173: //#define BLDCFG_UMA_ALLOCATION_SIZE 0x1000//0x1800//0x1000 /* (1000 << 16) = 256M*/
line over 96 characters
Patch Set #5, Line 173: //#define BLDCFG_UMA_ALLOCATION_SIZE 0x1000//0x1800//0x1000 /* (1000 << 16) = 256M*/
please, no space before tabs
Patch Set #5, Line 174: #define BLDCFG_UMA_ALLOCATION_SIZE 0x2000//512M
please, no space before tabs
that open brace { should be on the previous line
Patch Set #5, Line 231: { AMD_AP_MTRR_FIX64k_00000, 0x1E1E1E1E1E1E1E1E },
please, no spaces at the start of a line
Patch Set #5, Line 232: { AMD_AP_MTRR_FIX16k_80000, 0x1E1E1E1E1E1E1E1E },
please, no spaces at the start of a line
Patch Set #5, Line 233: { AMD_AP_MTRR_FIX16k_A0000, 0x0000000000000000 },
please, no spaces at the start of a line
Patch Set #5, Line 234: { AMD_AP_MTRR_FIX4k_C0000, 0x0000000000000000 },
please, no spaces at the start of a line
Patch Set #5, Line 235: { AMD_AP_MTRR_FIX4k_C8000, 0x0000000000000000 },
please, no spaces at the start of a line
Patch Set #5, Line 236: { AMD_AP_MTRR_FIX4k_D0000, 0x0000000000000000 },
please, no spaces at the start of a line
Patch Set #5, Line 237: { AMD_AP_MTRR_FIX4k_D8000, 0x0000000000000000 },
please, no spaces at the start of a line
Patch Set #5, Line 238: { AMD_AP_MTRR_FIX4k_E0000, 0x1818181818181818 },
please, no spaces at the start of a line
Patch Set #5, Line 239: { AMD_AP_MTRR_FIX4k_E8000, 0x1818181818181818 },
please, no spaces at the start of a line
Patch Set #5, Line 240: { AMD_AP_MTRR_FIX4k_F0000, 0x1818181818181818 },
please, no spaces at the start of a line
Patch Set #5, Line 241: { AMD_AP_MTRR_FIX4k_F8000, 0x1818181818181818 },
please, no spaces at the start of a line
Patch Set #5, Line 242: { CPU_LIST_TERMINAL }
please, no spaces at the start of a line
Patch Set #5, Line 245: #define BLDCFG_AP_MTRR_SETTINGS_LIST &TrinityApMtrrSettingsList
Macros with complex values should be enclosed in parentheses
Patch Set #5, Line 247: // This is the delivery package title, "BrazosPI"
code indent should use tabs where possible
Patch Set #5, Line 248: // This string MUST be exactly 8 characters long
code indent should use tabs where possible
Patch Set #5, Line 251: // This is the release version number of the AGESA component
code indent should use tabs where possible
Patch Set #5, Line 252: // This string MUST be exactly 12 characters long
code indent should use tabs where possible
Patch Set #5, Line 334: // The following definitions specify the default values for various parameters in which there are
line over 96 characters
Patch Set #5, Line 335: // no clearly defined defaults to be used in the common file. The values below are based on product
line over 96 characters
File src/mainboard/asus/a88xm-e/irq_tables.c:
Patch Set #5, Line 94: if (sum != pirq->checksum) {
braces {} are not necessary for single statement blocks
Patch Set #5, Line 98: printk(BIOS_INFO, "write_pirq_routing_table done.\n");
Prefer using '"%s...", __func__' to using 'write_pirq_routing_table', this function's name, in a string
File src/mainboard/asus/a88xm-e/mptable.c:
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 26: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 27: 0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 28: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 29: 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 30: 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 31: 0x1F,0x1F,0x1F,0x1F
space required after that ',' (ctx:VxV)
Patch Set #5, Line 31: 0x1F,0x1F,0x1F,0x1F
space required after that ',' (ctx:VxV)
Patch Set #5, Line 31: 0x1F,0x1F,0x1F,0x1F
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 34: 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 35: 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 36: 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 37: 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 38: 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
Patch Set #5, Line 39: 0x10,0x11,0x12,0x13
space required after that ',' (ctx:VxV)
Patch Set #5, Line 39: 0x10,0x11,0x12,0x13
space required after that ',' (ctx:VxV)
Patch Set #5, Line 39: 0x10,0x11,0x12,0x13
space required after that ',' (ctx:VxV)
Patch Set #5, Line 42: static void smp_add_mpc_entry(struct mp_config_table *mc, unsigned length)
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #5, Line 91: for (byte = 0x0; byte < sizeof(picr_data); byte ++) {
space prohibited before that '++' (ctx:WxB)
Patch Set #5, Line 97: for (byte = 0x0; byte < sizeof(intr_data); byte ++) {
space prohibited before that '++' (ctx:WxB)
Patch Set #5, Line 103: #define IO_LOCAL_INT(type, intr, apicid, pin) \
macros should not use a trailing semicolon
Patch Set #5, Line 104: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin));
line over 96 characters
Patch Set #5, Line 111: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, (bus), (((dev)<<2)|(int_sign)), ioapic_id, (pin))
line over 96 characters
File src/mainboard/asus/a88xm-e/romstage.c:
Patch Set #5, Line 31: #define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x))
Macros with complex values should be enclosed in parentheses
To view, visit change 30987. To unsubscribe, or for help writing mail filters, visit settings.