Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37289 ) Change subject: cpu/x86/smm: Add sinkhole mitigation to relocatable smmstub ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/37289/1/src/cpu/x86/smm/sinkhole.c File src/cpu/x86/smm/sinkhole.c: https://review.coreboot.org/c/coreboot/+/37289/1/src/cpu/x86/smm/sinkhole.c@... PS1, Line 31: printk(BIOS_EMERG, "Wrong LAPIC base detected! dying...\n"); hmm do we really want to link console code into the stub? -- To view, visit https://review.coreboot.org/c/coreboot/+/37289 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49927c4f4218552b732bac8aae551d845ad7f079 Gerrit-Change-Number: 37289 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 27 Nov 2019 17:45:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment