Attention is currently required from: Ethan Tsao, Paul Menzel, Subrata Banik, Raj Astekar, Patrick Rudolph, Felix Held.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 9: Modify IPC sub command to 2 from 0 for reading LPM requirement from PMC.
Hi Paul, […]
I think the gist of this is:
The command seems to work (return the correct values) with the
sub-command set to 0. However, the spec for the PMC interface
shows that the subommand for reading the LPM requirements registers
is 2, the `GEN_COMM_READ` sub-command. This patch corrects the
IPC command call (hopefully it was verified to still work).
To view, visit change 58317. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58509f14f1e67472adda78e65c3a2e3ee9210765
Gerrit-Change-Number: 58317
Gerrit-PatchSet: 2
Gerrit-Owner: Ethan Tsao <ethan.tsao@intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Raj Astekar <raj.astekar@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang@intel.com>
Gerrit-CC: Ethan Tsao <ethan.tsao@intel.corp-partner.google.com>
Gerrit-CC: Felix Held <felix-coreboot@felixheld.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Ethan Tsao <ethan.tsao@intel.corp-partner.google.com>
Gerrit-Attention: Ethan Tsao <ethan.tsao@intel.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Subrata Banik <subrata.banik@intel.com>
Gerrit-Attention: Raj Astekar <raj.astekar@intel.com>
Gerrit-Attention: Patrick Rudolph <siro@das-labor.org>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Mon, 25 Oct 2021 20:17:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ethan Tsao <ethan.tsao@intel.corp-partner.google.com>
Comment-In-Reply-To: Ethan Tsao <ethan.tsao@intel.com>
Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: comment