Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun.
1 comment:
File src/mainboard/google/rex/variants/rex0/overridetree.cb:
Patch Set #2, Line 84: register "thc_configuration" = "THC_CONFIG_DOUBLE_CONTROLLER"
This reads not very nice. […]
First, the name 'thc_configuration' is chosen instead of thc_config since 'config' has been used for chip.h instances in many places and we want to avoid the confusion.
THC has two controllers and two ports/interfaces. However, not all combinations are supported. In addition, there is limitation such that 1st controller must be enabled if 2nd one needs to be used, regardless of whether 1st one is used or not. For that, we have the following usage cases:
THC_CONFIG_NONE:
Both controllers are not enabled and direct SPI or I2C interface can be used for touch devices.
THC_CONFIG_SINGLE_PORT0:
First controller is enabled with port 0.
THC_CONFIG_SINGLE_PORT1: Currently, not available.
First controller is enabled with port 1.
THC_CONFIG_SINGLE_BOTH_PORTS: ( reserved for the future support)
First controller is enabled with both port 0 and port 1.
THC_CONFIG_DOUBLE_CONTROLLER:
Both controllers are enabled. We only has two interface ports, therefore each one is with port 0 and port 1 respectively. It is not possible to have THC0 use port1 and THC1 use port 0.
These above usage defines should help on how the enum value names come from.
In Rex case, we only want to use 2nd THC with port 1. But, due to the configuration constraint, THC0 needs also be enabled. Therefore, THC_CONFIG_DOUBLE_CONTROLLER is used.
To view, visit change 81333. To unsubscribe, or for help writing mail filters, visit settings.