Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Tim Chu.

Patrick Rudolph has uploaded this change for review.

View Change

soc/intel/xeon_sp: Drop unused helper functions

Change-Id: Ib319643f6b0b91d8c5854da531e035d333f04d75
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
M src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h
M src/soc/intel/xeon_sp/cpx/soc_util.c
M src/soc/intel/xeon_sp/skx/include/soc/soc_util.h
M src/soc/intel/xeon_sp/skx/soc_util.c
M src/soc/intel/xeon_sp/spr/include/soc/soc_util.h
M src/soc/intel/xeon_sp/spr/soc_util.c
6 files changed, 0 insertions(+), 31 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/80143/1
diff --git a/src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h b/src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h
index c3d07af..d1ce7bf 100644
--- a/src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h
+++ b/src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h
@@ -25,7 +25,6 @@
const struct SystemMemoryMapHob *get_system_memory_map(void);

uint8_t socket0_get_ubox_busno(const uint8_t stack);
-uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack);
uint8_t get_cxl_node_count(void);

int soc_get_stack_for_port(int port);
diff --git a/src/soc/intel/xeon_sp/cpx/soc_util.c b/src/soc/intel/xeon_sp/cpx/soc_util.c
index 240a185..fd97a09 100644
--- a/src/soc/intel/xeon_sp/cpx/soc_util.c
+++ b/src/soc/intel/xeon_sp/cpx/soc_util.c
@@ -47,15 +47,6 @@
return pci_io_read_config32(dev, offset) >> (8 * (stack % 4)) & 0xff;
}

-uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack)
-{
- const IIO_UDS *hob = get_iio_uds();
-
- assert(socket < CONFIG_MAX_SOCKET && stack < MAX_LOGIC_IIO_STACK);
-
- return hob->PlatformData.IIO_resource[socket].StackRes[stack].BusBase;
-}
-
/*
* EX: CPX-SP
* Ports Stack Stack(HOB) IioConfigIou
diff --git a/src/soc/intel/xeon_sp/skx/include/soc/soc_util.h b/src/soc/intel/xeon_sp/skx/include/soc/soc_util.h
index b86322c..0c4f998 100644
--- a/src/soc/intel/xeon_sp/skx/include/soc/soc_util.h
+++ b/src/soc/intel/xeon_sp/skx/include/soc/soc_util.h
@@ -11,7 +11,6 @@
const struct SystemMemoryMapHob *get_system_memory_map(void);

uint8_t socket0_get_ubox_busno(const uint8_t stack);
-uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack);

int soc_get_stack_for_port(int port);
uint8_t get_cxl_node_count(void);
diff --git a/src/soc/intel/xeon_sp/skx/soc_util.c b/src/soc/intel/xeon_sp/skx/soc_util.c
index 53f3cc4..1b347a0 100644
--- a/src/soc/intel/xeon_sp/skx/soc_util.c
+++ b/src/soc/intel/xeon_sp/skx/soc_util.c
@@ -77,15 +77,6 @@
return pci_io_read_config32(dev, offset) >> (8 * (stack % 4)) & 0xff;
}

-uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack)
-{
- const IIO_UDS *hob = get_iio_uds();
-
- assert(socket < MAX_SOCKET && stack < MAX_IIO_STACK);
-
- return hob->PlatformData.CpuQpiInfo[socket].StackBus[stack];
-}
-
void config_reset_cpl3_csrs(void)
{
uint32_t data, plat_info, max_min_turbo_limit_ratio;
diff --git a/src/soc/intel/xeon_sp/spr/include/soc/soc_util.h b/src/soc/intel/xeon_sp/spr/include/soc/soc_util.h
index a7bf06c..631601e 100644
--- a/src/soc/intel/xeon_sp/spr/include/soc/soc_util.h
+++ b/src/soc/intel/xeon_sp/spr/include/soc/soc_util.h
@@ -31,8 +31,6 @@
const struct SystemMemoryMapHob *get_system_memory_map(void);
const struct SystemMemoryMapElement *get_system_memory_map_elment(uint8_t *num);

-uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack);
-
bool is_iio_cxl_stack_res(const STACK_RES *res);

void soc_display_iio_universal_data_hob(const IIO_UDS *hob);
diff --git a/src/soc/intel/xeon_sp/spr/soc_util.c b/src/soc/intel/xeon_sp/spr/soc_util.c
index f26eca4..9af9002 100644
--- a/src/soc/intel/xeon_sp/spr/soc_util.c
+++ b/src/soc/intel/xeon_sp/spr/soc_util.c
@@ -130,15 +130,6 @@
return count;
}

-uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack)
-{
- const IIO_UDS *hob = get_iio_uds();
-
- assert(socket < CONFIG_MAX_SOCKET && stack < MAX_LOGIC_IIO_STACK);
-
- return hob->PlatformData.IIO_resource[socket].StackRes[stack].BusBase;
-}
-
/* Returns the UBOX(offset) bus number for socket0 */
uint8_t socket0_get_ubox_busno(uint8_t offset)
{

To view, visit change 80143. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib319643f6b0b91d8c5854da531e035d333f04d75
Gerrit-Change-Number: 80143
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter@9elements.com>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-MessageType: newchange