3 comments:
File util/cbfstool/cbfstool.c:
Patch Set #8, Line 91: struct mh_cache {
I don't see comments, if any, in this patch. It's hard to follow intended semantics.
Added a couple of comments.
Patch Set #8, Line 149: (void *)-1
Why are we updating a pointer to this value? -1 is also not a valid pointer size.
I was just using the .region member to check whether the structure has been initialized yet, so I needed to store a non-NULL bogus value here. I instead added an explicit `initialized` struct member now to make it more readable.
Patch Set #8, Line 175: ERROR("Metadata hash anchor no longer where it used to be!\n");
Is that possible? If so, we should discuss how that could happen in the commentary of the code.
No, I don't think it should be. Changed to assert() to clarify that.
To view, visit change 41121. To unsubscribe, or for help writing mail filters, visit settings.