Attention is currently required from: Angel Pons.
Patrick Rudolph has uploaded this change for review.
nb/intel/sandybridge/raminit: Only write register on IvyBridge
Only write register WMM_READ_CONFIG on Ivy Bridge as it's
reserved on Sandy Bridge.
Tested on Lenovo X220: Still boots and runs fine.
Change-Id: Ie14ea06d744b1a8368d32803c6c1ccfb1262532e
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
M src/northbridge/intel/sandybridge/raminit_common.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/79761/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c
index c62e1cd..50c0fb4 100644
--- a/src/northbridge/intel/sandybridge/raminit_common.c
+++ b/src/northbridge/intel/sandybridge/raminit_common.c
@@ -2815,8 +2815,8 @@
int t3_ns;
u32 r32;
- /* FIXME: This register only exists on Ivy Bridge */
- mchbar_write32(WMM_READ_CONFIG, 0x46);
+ if (IS_IVY_CPU(ctrl->cpu))
+ mchbar_write32(WMM_READ_CONFIG, 0x46);
FOR_ALL_CHANNELS {
union tc_othp_reg tc_othp = {
To view, visit change 79761. To unsubscribe, or for help writing mail filters, visit settings.