Attention is currently required from: Nico Huber, Matt DeVillier, Arthur Heymans, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55810 )
Change subject: broadwell boards: Do not set `ddr_refresh_2x` again
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/auron/variants/buddy/spd/spd.c:
https://review.coreboot.org/c/coreboot/+/55810/comment/d605d769_ca7090d6
PS9, Line 13: pei_data->ddr_refresh_2x = 1;
ddr_refresh_2x is a rowhammer mitigation. […]
What difference would it make? soc/intel/broadwell/pei_data.c function `broadwell_fill_pei_data()` already sets this unconditionally since CB:9590
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76478689b3aa27c369a0413d9fbde03674d5e528
Gerrit-Change-Number: 55810
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 01 Nov 2021 21:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment