3 comments:
File src/mainboard/google/hatch/variants/baseboard/memory.c:
Patch Set #6, Line 60: for (int i = 0; i < ARRAY_SIZE(bcfg->spd); i++) {
If bcfg->spd has more than 4 elements, the calculation to index into bcfg->channel_empty[] will read past the end of that array. Please use an assert() or a die() to protect against this failure case.
File src/mainboard/google/hatch/variants/kohaku/memory.c:
Patch Set #6, Line 90: for (int i = 0; i < ARRAY_SIZE(bcfg->spd); i++) {
Same comment as for baseboard/memory.c line 60
File src/soc/intel/cannonlake/include/soc/cnl_memcfg_init.h:
Patch Set #6, Line 67: struct spd_info spd[4];
The #define that Patrick Rudolph requested in cnl_memcfg_init.c line 60, please use that in the array definition here.
To view, visit change 32513. To unsubscribe, or for help writing mail filters, visit settings.