View Change

4 comments:

• File src/arch/x86/acpi_bert_storage.c:

  • Patch Set #2, Line 350: 3

    is this CPER_IA32X64_CTX_64BIT_EX?

  • Patch Set #2, Line 399: cpuid_eax

    use "struct cpuid_result" and cpuid() instead of calling cpuid 4 times?

  • Patch Set #2, Line 519: *start = NULL;

    Add a printf stating that the weak function was called and that a full implementation must be added?

     printk(BIOS_ERR, "Error: %s not implemented.  BERT region generation disabled", __func__);

• File src/arch/x86/include/arch/bert_storage.h:

  • Patch Set #2, Line 88: acpi_hest_generic_data_nth

    Why make this inline?

To view, visit change 28470. To unsubscribe, or for help writing mail filters, visit settings.