Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41440 )
Change subject: sconfig: Add support for firmware configuration
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41440/1/util/sconfig/sconfig.y
File util/sconfig/sconfig.y:
https://review.coreboot.org/c/coreboot/+/41440/1/util/sconfig/sconfig.y@85
PS1, Line 85: strtoul($<string>3,
I actually started with $<number> here and ran into issues before realizing that everything else was […]
It complains about type mismatches and I tried to untangle but it ended up touching a lot more code so I'm leaving it alone for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41440
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8aea63e577d933aea09e0d0b09470929cc96e0de
Gerrit-Change-Number: 41440
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 17 May 2020 17:17:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment