Jacob Garber uploaded patch set #2 to this change.

View Change

cpu,mb,soc: Init missing lb_serial struct fields

Initialize the input_hertz field of the lb_serial struct to prevent
later undefined reads in lb_add_serial(). This was done for exynos5420
in commit ff94e00362 (soc/samsung/exynos5420/uart.c: Init new serial
struct variables), and this patch finishes the rest. Also, move the
assignment of uart_pci_addr into lb_add_serial() and set it to
CONFIG_UART_PCI_ADDR, since it is the same for all the drivers.

Change-Id: I733bc8185e2f2d28a9823495b53d6b09dce4deb1
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1354778
---
M src/cpu/allwinner/a10/uart_console.c
M src/cpu/ti/am335x/uart.c
M src/drivers/uart/pl011.c
M src/drivers/uart/uart8250io.c
M src/drivers/uart/uart8250mem.c
M src/lib/coreboot_table.c
M src/mainboard/emulation/qemu-power8/uart.c
M src/soc/imgtec/pistachio/uart.c
M src/soc/mediatek/common/uart.c
M src/soc/nvidia/tegra124/uart.c
M src/soc/nvidia/tegra210/uart.c
M src/soc/qualcomm/ipq40xx/uart.c
M src/soc/qualcomm/qcs405/uart.c
M src/soc/samsung/exynos5250/uart.c
M src/soc/samsung/exynos5420/uart.c
15 files changed, 13 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/34548/2

To view, visit change 34548. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I733bc8185e2f2d28a9823495b53d6b09dce4deb1
Gerrit-Change-Number: 34548
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber <jgarber1@ualberta.ca>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Jacob Garber <jgarber1@ualberta.ca>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-MessageType: newpatchset