Patch Set 7: -Code-Review

Thinking about it further, are fsp_params significantly different between JSL and TGL.

If the difference is small, then we can keep the differences alone in the fsp_params_${soc}.c and keep the common parts in the fsp_params.c.

Hi Karthik,
Yes, there is significant delta between fsp_param for jsl and tgl (I would say around 40% is common). So even if we move out common params, files would be still bigger and it may be confusing to people.

I feel it will be good to keep fsp_params separately which will also help in debug in case of any issues since we know exactly which files are being compiled for which soc.

View Change

To view, visit change 37267. To unsubscribe, or for help writing mail filters, visit settings.