Patch Set 1:


- Line 561: "_weak" so that it can be if needed for som platform/soc
- Line 829: I agree that the entry point should be added as as specified in SMBIOS 3.0. it would be more disruptive in this CL, as the change will also need to go in other other files where the table entry are used.
I suggest having a later patch and review exclusively for the table entry update.

View Change


To view, visit change 32090. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1171c20ac85a2231d949d4ac1c3e3c544ba3e5ef
Gerrit-Change-Number: 32090
Gerrit-PatchSet: 5
Gerrit-Owner: Francois Toguo Fotso <>
Gerrit-Reviewer: Francois Toguo Fotso <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: Paul Menzel <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Francois Toguo Fotso <>
Gerrit-CC: Lijian Zhao <>
Gerrit-CC: Patrick Rudolph <>
Gerrit-Comment-Date: Thu, 28 Mar 2019 21:36:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <>
Comment-In-Reply-To: Paul Menzel <>
Comment-In-Reply-To: Nico Huber <>
Gerrit-MessageType: comment