Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32090 )
Change subject: smbios: Add and adapt fields for version 3.2 ......................................................................
Patch Set 5:
Patch Set 1:
Patrick, - Line 561: "_weak" so that it can be if needed for som platform/soc - Line 829: I agree that the entry point should be added as as specified in SMBIOS 3.0. it would be more disruptive in this CL, as the change will also need to go in other other files where the table entry are used. I suggest having a later patch and review exclusively for the table entry update.
https://review.coreboot.org/#/c/32090/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32090/1//COMMIT_MSG@7 PS1, Line 7: src/arch: This is an upgrade of SMBIOS to latest version 3.2
Please use a verb in imperative mood, cf `git log --oneline` for how to word git commit summaries. […]
https://review.coreboot.org/#/c/32090/1//COMMIT_MSG@9 PS1, Line 9: This is the second of 2 patches upgrading the SMBIOS interface to the latest 3.2 : First patch is in mosys. Newer required fields are added to various types definitions
Please add dots to the end of sentences. […]
https://review.coreboot.org/#/c/32090/1//COMMIT_MSG@11 PS1, Line 11:
I think most of all, this commit message needs to give a reason […]
https://review.coreboot.org/#/c/32090/1/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32090/1/src/arch/x86/smbios.c@570 PS1, Line 570: !(leaf_b.eax | leaf_b.ebx | leaf_b.ecx | leaf_b.edx))
Please indent the condition.
https://review.coreboot.org/#/c/32090/1/src/arch/x86/smbios.c@824 PS1, Line 824: se->major_version = 2;
update to 3
https://review.coreboot.org/#/c/32090/1/src/arch/x86/smbios.c@825 PS1, Line 825: se->minor_version = 7;
update to 2