1 comment:
Patch Set #1, Line 27: int gpio_get_output(gpio_t gpio);
This is a pretty odd use case, I think it might be better to just have this function at the platform level. I can see how it makes sense for x86 SMM, but in other architectures without runtime components it doesn't really come up that you wouldn't know what value a certain pin is set to.
If you do want to add this to the generic API, please move it away from those other definitions (because the comment above says these are required), and add a comment clarifying that this one is optional.
To view, visit change 34189. To unsubscribe, or for help writing mail filters, visit settings.