Patch Set 4:

>> Please update the commit message and provide some
>> reasoning for this.
>
> I already mentioned there the only benefit I knew at the moment of submission:
> "This provides console output even if e.g. GRUB is the payload."

Are you sure you tested that this patch, in its current
version, applied to upstream coreboot, with the resulting
default config, makes a difference?

It's not me but HJK who discovered this effect, and he did it with coreboot 4.8 at November 2018. Here is his full message from the archives: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/LRKJPXK4D3YEX54GIQBZW5FTDJ3QOGBG/ . Sorry, I really should have said it at the beginning and also add "Signed-off-by: Hans Jürgen Kitter <eforname@freemail.hu>" to this patch as well.

To be honest, personally I'm a bit indifferent to this particular change because it does not change anything for me; but if turns out that it benefits some - e.g. at least those who are using a splash screen - then I'll be happy for doing a good thing for them. It would be much easier for me to test a splash screen than GRUB console output (and I never tried GRUB with coreboot yet), so I will be testing a splashscreen soon - and if there's a difference, perhaps the GRUB reasoning will be replaced with a splashscreen one.

View Change

To view, visit change 31325. To unsubscribe, or for help writing mail filters, visit settings.