Patch Set 9:

Patch Set 9:

Patch Set 9:

Patch Set 9: Code-Review-1

this is also used to cache postcar stage uitside cbmem

this config is mainly depends on relocatable ranstage config, not sure why we have created a config which has root dependency on ramstage but use across romstage, postcar and ramstage

postcarstage is always relocatable. so the depency is on either have_relocatable_ramstage or postcar_stage

then, i guess kconfig name should reflect the same. isn't it ?

Yes. How about renaming it to "config EXTERNAL_STAGE_CACHE" that depends on RELOCATABLE_RAMSTAGE || POSTCAR_STAGE ?

View Change

To view, visit change 33116. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45e894ad335a4661cc7916b3768e1614a038b31c
Gerrit-Change-Number: 33116
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 09 Jun 2019 08:56:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment