Patch set 8:Code-Review +1
3 comments:
File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
Patch Set #8, Line 16: uintptr_t
why is this an uintptr_t? it's not really a pointer to anything
Patch Set #8, Line 23: spd_index = (board_id & BIT_4_0) & BIT_2_0;
Hmm, this is essentially the same as `board_id & BIT_2_0`. Is it correct?
File src/mainboard/intel/adlrvp/variants/adlrvp_p/devicetree.cb:
Patch Set #7, Line 8: register "SaGv" = "SaGv_Disabled"
Tim, Default is subject to change over FSP version, in latest code I'm seeing default is 0x5 enable […]
Sounds good.
To view, visit change 46091. To unsubscribe, or for help writing mail filters, visit settings.