Attention is currently required from: Tarun Tuli, Subrata Banik, Derek Huang, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg.

Derek Huang uploaded patch set #12 to this change.

View Change

src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown

When AP boots up after Cr50 firmware update and reboot, AP finds
that Cr50 reset is required for Cr50 to pick the new firmware so
it trigger Cr50 reset and power off the system, AP expects system
will power on automatically after Cr50 reset. However this is not
the case for Chromebox, Chromebox EC set AP_IDLE flag when system
is shutting down, when AP_IDLE flag is set in EC, the system stays
at S5/G3 and wait for power button presssend. It cause an issue in
factory that the operator needs to press power button to power on
the DUT after Cr50 firmware update.

This patch sends EC command to direct EC to clear AP_IDLE flag
after AP shutdown so AP can boot up when Cr50 reset.

BUG=b:261119366
BRANCH=firmware-brya-14505.B
TEST=DUT boots up after Cr50 firmware update in factory test flow

Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b
Signed-off-by: Derek Huang <derekhuang@google.com>
---
M src/ec/google/chromeec/ec_commands.h
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/mainboard.c
M src/vendorcode/google/chromeos/cr50_enable_update.c
4 files changed, 51 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/70773/12

To view, visit change 70773. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b
Gerrit-Change-Number: 70773
Gerrit-PatchSet: 12
Gerrit-Owner: Derek Huang <derekhuang@google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm@google.com>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Daisuke Nojiri <dnojiri@chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli@google.com>
Gerrit-CC: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli@google.com>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Derek Huang <derekhuang@google.com>
Gerrit-Attention: Caveh Jalali <caveh@chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Attention: Daisuke Nojiri <dnojiri@chromium.org>
Gerrit-Attention: Boris Mittelberg <bmbm@google.com>
Gerrit-MessageType: newpatchset