Patch Set 34: Code-Review+1

Patch Set 34:

Patch Set 32: Code-Review+1

(2 comments)

Thanks for addressing the comments, Mike. I think this can go in after addressing the things in cmos.layout and after Balázs replies to the other comments :)

Thank you very much for your kind help, wish you a Happy New Year ;)

Happy New Year to you as well :)

Do you think romstage.c code could be carefully moved to bootblock.c ? I'm also thinking about how to replace inb(0xcd7) with something like pm_read8, just like outb is replaced with pm_write8. Last time I tried I couldn't do it, so at AM1I-A merged change CB:37829 I had to leave it as inb.

It would be nice. However, after such a change, I'd like to have this change boot-tested.

I answered a couple of questions, but some of them remain without any comment.

Regards

View Change

6 comments:

• File Documentation/mainboard/asus/a88xm-e.md:

  • Patch Set #31, Line 98: Kaveri

    for Balazs to address

    yes, it is.

• File src/mainboard/asus/a88xm-e/Kconfig:

  • Patch Set #31, Line 85:

    config ONBOARD_VGA_IS_PRIMARY
    	bool
    	default y
    

    question for Balazs

    This is needed for the configuration, what I use

  • Patch Set #31, Line 93:

    config CONFIG_DRIVERS_PS2_KEYBOARD
    	bool
    	default y
    

    question for Balazs

    the board has dedicated PS2 ports for keyboard and mouse

  • Patch Set #31, Line 105:

    config POST_IO
    	bool
    	default n
    
    config CONFIG_POST_DEVICE_PCI_PCIE
    	bool
    	default y
    

    question for Balazs

    I have an external PCI debugger which was used

• File src/mainboard/asus/a88xm-e/OemCustomize.c:

  • Patch Set #30, Line 170: InitPost->MemConfig.PlatformMemoryConfiguration = (PSO_ENTRY *) MemoryTable_XM_E;

    line over 96 characters

    Ack

• File src/mainboard/asus/a88xm-e/bootblock.c:

  • Patch Set #30, Line 23: #define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x))

    Macros with complex values should be enclosed in parentheses

    Ack

To view, visit change 30987. To unsubscribe, or for help writing mail filters, visit settings.