Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33620 ) Change subject: soc/amd: Update ACPI code ...................................................................... Patch Set 2:
I think you should separate your OS stuff into a separate stack. Keep the additional cores change for the merlinfalcon work. This is for merlinfalcon, as the same ASL is used both for stoneyridge and merlinfalcon.
I understand that. My suggestion is that maybe you shouldn't be trying to fix OS incompatibilities on Stoney Ridge until you have more information. Simply make a stack that adds Merlin Falcon support to the stoneyridge directory. This will be a lot easier to review and approve than a stack containing unrelated ACPI changes. Or you could move the ACPI changes to the top of the stack, maybe, because this shouldn't affect making stoneyridge backward compatible. -- To view, visit https://review.coreboot.org/c/coreboot/+/33620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3615a4460dd4e0c95e890a38210263dd8ea6887 Gerrit-Change-Number: 33620 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> Gerrit-Reviewer: Charles Marslett <charles.marslett@silverbackltd.com> Gerrit-Reviewer: Lance Zhao <lance.zhao@gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Mon, 24 Jun 2019 14:46:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment