Attention is currently required from: Dolan Liu, Elyes Haouas, Jianeng Ceng, Paul Menzel, Subrata Banik.
View Change
2 comments:
Commit Message:
Patch Set #24, Line 9:
In order to be different from rt5663, the driver of RT5645 is
specially declared.
Sorry, just reading this, I do not understand. Please list the differences.
while the wording here is slightly awkward, I don't see enumerating the differences between the two drivers/chips in the commit msg being useful or necessary. Simply stating that the RT5645/5650 are different enough from the RT5663 to warrant a separate implementation is sufficient IMO
Patch Set #24, Line 17:
Please also mention, that you hide the device because of Microsoft Windows.
or stated another way, the ACPI device is being created specifically for Linux
To view, visit change 81773. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 24
Gerrit-Owner: Jianeng Ceng <cengjianeng@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas@noos.fr>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Dolan Liu <liuyong5@huaqin.corp-partner.google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng@huaqin.corp-partner.google.com>
Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Comment-Date: Mon, 22 Apr 2024 15:35:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: comment