Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60769 )
Change subject: soc/amd/common/block/espi: use lower case hex digits in definitions ......................................................................
soc/amd/common/block/espi: use lower case hex digits in definitions
coreboot uses lower case hex digits instead of upper case ones.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I0955db7afd101ab522845d5911ff971408e520e3 --- M src/soc/amd/common/block/include/amdblocks/espi.h M src/soc/amd/common/block/lpc/espi_util.c 2 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/60769/1
diff --git a/src/soc/amd/common/block/include/amdblocks/espi.h b/src/soc/amd/common/block/include/amdblocks/espi.h index adb9a1d..4e8b898 100644 --- a/src/soc/amd/common/block/include/amdblocks/espi.h +++ b/src/soc/amd/common/block/include/amdblocks/espi.h @@ -21,7 +21,7 @@ #define ESPI_MMIO_BASE_OFFSET_REG0 0x50 #define ESPI_MMIO_BASE_OFFSET_REG1 0x54 #define ESPI_MMIO_BASE_OFFSET_REG2 0x58 -#define ESPI_MMIO_BASE_OFFSET_REG3 0x5C +#define ESPI_MMIO_BASE_OFFSET_REG3 0x5c #define ESPI_MMIO_OFFSET_SIZE_REG0 0x60 #define ESPI_MMIO_OFFSET_SIZE_REG1 0x64
diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index d9b4715..f36f778 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -336,9 +336,9 @@
#define ESPI_GLOBAL_CONTROL_0 0x30 #define ESPI_WAIT_CNT_SHIFT 24 -#define ESPI_WAIT_CNT_MASK (0x3F << ESPI_WAIT_CNT_SHIFT) +#define ESPI_WAIT_CNT_MASK (0x3f << ESPI_WAIT_CNT_SHIFT) #define ESPI_WDG_CNT_SHIFT 8 -#define ESPI_WDG_CNT_MASK (0xFFFF << ESPI_WDG_CNT_SHIFT) +#define ESPI_WDG_CNT_MASK (0xffff << ESPI_WDG_CNT_SHIFT) #define ESPI_AL_IDLE_TIMER_SHIFT 4 #define ESPI_AL_IDLE_TIMER_MASK (0x7 << ESPI_AL_IDLE_TIMER_SHIFT) #define ESPI_AL_STOP_EN (1 << 3) @@ -348,20 +348,20 @@
#define ESPI_GLOBAL_CONTROL_1 0x34 #define ESPI_RGCMD_INT_MAP_SHIFT 13 -#define ESPI_RGCMD_INT_MAP_MASK (0x1F << ESPI_RGCMD_INT_MAP_SHIFT) +#define ESPI_RGCMD_INT_MAP_MASK (0x1f << ESPI_RGCMD_INT_MAP_SHIFT) #define ESPI_RGCMD_INT(irq) ((irq) << ESPI_RGCMD_INT_MAP_SHIFT) -#define ESPI_RGCMD_INT_SMI (0x1F << ESPI_RGCMD_INT_MAP_SHIFT) +#define ESPI_RGCMD_INT_SMI (0x1f << ESPI_RGCMD_INT_MAP_SHIFT) #define ESPI_ERR_INT_MAP_SHIFT 8 -#define ESPI_ERR_INT_MAP_MASK (0x1F << ESPI_ERR_INT_MAP_SHIFT) +#define ESPI_ERR_INT_MAP_MASK (0x1f << ESPI_ERR_INT_MAP_SHIFT) #define ESPI_ERR_INT(irq) ((irq) << ESPI_ERR_INT_MAP_SHIFT) -#define ESPI_ERR_INT_SMI (0x1F << ESPI_ERR_INT_MAP_SHIFT) +#define ESPI_ERR_INT_SMI (0x1f << ESPI_ERR_INT_MAP_SHIFT) #define ESPI_SUB_DECODE_SLV_SHIFT 3 #define ESPI_SUB_DECODE_SLV_MASK (0x3 << ESPI_SUB_DECODE_SLV_SHIFT) #define ESPI_SUB_DECODE_EN (1 << 2) #define ESPI_BUS_MASTER_EN (1 << 1) #define ESPI_SW_RST (1 << 0)
-#define ESPI_SLAVE0_INT_EN 0x6C +#define ESPI_SLAVE0_INT_EN 0x6c #define ESPI_SLAVE0_INT_STS 0x70 #define ESPI_STATUS_DNCMD_COMPLETE (1 << 28) #define ESPI_STATUS_NON_FATAL_ERROR (1 << 6)