Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30825 )
Change subject: Revert "soc/intel: Clean mess around UART_DEBUG" ......................................................................
Patch Set 2:
Patch Set 2:
As i could see u need this original CL because of some customer requirement but that CL causes issue on all chrome platform that i know like CNL, ICL etc. so, what will be trade-off to satisfy both platfom. because its all IA platform and we want to provide solution to all. :)
There was no customer requirement. Only my own sense for quality. As coreboot quality was degrading much after Intel started to work upstream, I started to clean up after you. As you can imagine, there isn't a lot testing involved when a single person cleans up after whole teams.
The following is from coreboot guideline.
Test your patches before submitting them to gerrit. It’s also appreciated if you add a line to the commit message describing how the patch was tested. This prevents people from having to ask whether and how the patch was tested. Examples of this sort of comment would be ‘TEST=Built platform’ or ‘Tested by building and booting platform’. Stating that the patch was not tested is also fine, although you might be asked to do some testing in cases where that would be reasonable.
I am appreciated for your contribution and thanks a lot for the clean up, please help review my following patch as well.