This: 25 files changed, 63 insertions(+), 49 deletions(-)
CB:34664 19 files changed, 30 insertions(+), 31 deletions(-)
Off-topic, *shrug*, just my five cents
Often the commits going less back-and-forth, not introducing redundant Kconfig options and with better argumentation in general get picked for merge.
Sometimes reviewers (at least I) get tired of scrolling through 30 odd patchsets or 100+ comments in a seemingly simple commit that was supposed to be a simple rename. I try to defer myself from doing +2 reviews while frustrated on the process, just to avoid errors and the need for reverts. If I see little value in the past review commments, I am not worried about upsetting someone by starting it from scratch with a fresh Change-Id.
Most of the time, arguments like "But I need this merged now" and "We are in a hurry" will just backfire with bikeshedding. Even more so today with the enforced ACR.
Last, and I have stated this somewhere before, there should be a 3-form application to fill for adding any Kconfig variables. That's how I feel about attacking a non-problem in Kconfig by adding yet another new variable.
To view, visit change 33116. To unsubscribe, or for help writing mail filters, visit settings.