Attention is currently required from: Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46386 ) Change subject: mb/google/asurada: Add Chrome OS GPIOs ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/asurada/chromeos.c: https://review.coreboot.org/c/coreboot/+/46386/comment/e6f6d8b6_5e1201c6 PS7, Line 25: ACTIVE_HIGH From the schematics, "H1_AP_INT_ODL" should be ACTIVE_LOW, right? -- To view, visit https://review.coreboot.org/c/coreboot/+/46386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeeee88a09ae4c3af15e2ae93a29684d30dde493 Gerrit-Change-Number: 46386 Gerrit-PatchSet: 7 Gerrit-Owner: Yidi Lin <yidi.lin@mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Yidi Lin <yidi.lin@mediatek.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 08:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment