View Change
1 comment:
File toolchain.inc:
Patch Set #3, Line 50: ifeq ($(CONFIG_RAMPAYLOAD),y)
Today ARCH_RAMSTAGE_X86 is the way to tell if we like to build ramstage or not. At least thats how coreboot soc is structured now.
That's not true. That's what you're trying to turn it into and I'm trying to argue to please not do that. ;)
Today ARCH_RAMSTAGE_X86 tells what architecture the ramstage is and nothing else. There is no way to not build a ramstage today. There is a way to not build two other stages (verstage and postcar), but for both of those the option that controls whether the stage is built is completely orthogonal to the option that controls with architecture it is (and the latter is usually still set even if the former is not... e.g. ARCH_VERSTAGE_X86 is still set even if SEPERATE_VERSTAGE=n).
To view, visit change 33143. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id000dfac2eb57a8eaaa505c89d798fb30b3706fe
Gerrit-Change-Number: 33143
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 04 Jun 2019 21:20:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik@intel.com>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: comment