Attention is currently required from: Duncan Laurie, John Zhao, Tim Wawrzynczak, Brandon Breitenstein.
1 comment:
File src/drivers/intel/usb4/retimer/retimer.c:
const char *RFWU = mainboard_retimer_fw_update_path();
/*
* Get information to set retimer info from Arg3[0]
* Local0 = DeRefOf (Arg3[0])
*/
acpigen_get_package_op_element(ARG3_OP, 0, LOCAL0_OP);
/*
* Write the EC RAM for Retimer Upgrade
* RFWU = LOCAL0
*/
acpigen_write_store();
acpigen_emit_byte(LOCAL0_OP);
acpigen_emit_namestring(RFWU);
/* Return (Zero) */
acpigen_write_return_integer(0);
I think we should put this entire function in the EC code, this way if the EC either doesn't impleme […]
In kernel, in my current implementation, the USB4 SW CM accesses these DSM methods using ACPI handle to the TDM0 device (via ACPI_HANDLE(&sw->tb->nhi->pdev->dev)). If this were to be moved to EC code, the implementation in kernel has to be changed. Currently USB4 SW CM does not have any information about the EC device and I am not sure if that's possible to use the EC device from within USB4 SW CM.
This is also something that we aligned earlier on the implementation details around USB4 retimer FW update. Would be nice if we can stick with this existing design.
Kernel checks for a minimum support for all these 5 functions (0x1F) via query_fn. In designs where it is not supported, we can simply return 0, so kernel does not do anything special about this.
To view, visit change 48630. To unsubscribe, or for help writing mail filters, visit settings.