View Change

2 comments:

• File src/mainboard/gigabyte/ga-b75m-d3h/Kconfig:

  • Patch Set #14, Line 43:

    config ROMSTAGE_C
    	string
    	default "romstage.c"
    

    Why is this needed? mainbaord/romstage.c is included from arch/x86/Makefile. […]

    This looks familiar... It's the GPIO_C thing on asus/p5qc, but renamed to ROMSTAGE_C. There's several differences between gpio.c and romstage.c that make this Kconfig value unnecessary for romstage.c:

    gpio.c files are usually meant to be used for a single board variant, so on variants there isn't a mainboard-level gpio.c in most cases. The mainboard Makefile.inc needs to explicitly include them (other platforms might use something different).

    romstage.c files, however, are more generic. If anything variant-specific is needed, it can be moved into variant/*/romstage.c, so that the mainboard-level romstage.c can still be the same for all the variants. Conditional code that depends on Kconfig symbols could also be used.
    The mainboard-level romstage.c is automatically built if it exists, but the variant-specific romstage.c files need to be explicitly included (not everyone needs variants).

    In the asus/p5qc case, two variants used the same gpio.c file, placed at the mainboard level (which is unusual). When p5ql_pro, which uses a different gpio.c, was added into the mix, something had to be done. Duplicating the shared gpio.c isn't an option, so the silly GPIO_C Kconfig symbol was the least evil kludge I could think of. (Yes, I wrote such an ugly thing)

    TL;DR in this case, and for now, no variant romstage.c is needed. The ugly GPIO_C-like kludge in asus/p5qc isn't needed here either.

• File src/mainboard/gigabyte/ga-b75m-d3h/Makefile.inc:

  • Patch Set #14, Line 19: romstage-y += $(CONFIG_ROMSTAGE_C)

    This, plus the strip call above, aren't needed. See the comments on Kconfig.

To view, visit change 32708. To unsubscribe, or for help writing mail filters, visit settings.