Attention is currently required from: Cliff Huang, Eran Mitrani, Eric Lai, Jingyuan Liang, Kyoung Il Kim.

View Change

18 comments:

• Commit Message:

  • Patch Set #4, Line 9: controller(THC)

    Please add space before the (.

  • Patch Set #4, Line 14: Meteorlake

    Meteor Lake

• File src/drivers/intel/touch/chip.h:

  • Patch Set #4, Line 11: MAX_TOUCH_PORTS

    MAX_TOUCH_PORTS_PER_CONTROLLER?

  • Patch Set #4, Line 23: Meteorlake

    Meteor Lake

  • Patch Set #4, Line 30:

    /* Touch Host Controller's (THC) 3 protocol modes:
    	 * Switch among IPTS, HID-SPI and HID-I2C.
    	 * 0x0: THC IPTS (not supported at this time)
    	 * 0x1: THC HID SPI
    	 * 0x2: THC HID I2C (for future support)
    	 */
    

    Blank line at the top.

        /*
         * […]
         * /

  • Patch Set #4, Line 45: unsigned int enable_delay_ms;

    Is there a better name? `delay_after_enabling_device_ms`?

  • Patch Set #4, Line 57: rpt

    I’d use report.

  • Patch Set #4, Line 63:

    /* Touch Host Controller Wake On Touch
    	   Based on this setting vGPIO for given THC will be in native mode, and additional
    	  _CRS for wake will be exposed in ACPI
    	*/
    

    Please use the recommended commenting styles.

  • Patch Set #4, Line 70: Spi

    SPI

  • Patch Set #4, Line 71: this

    This

  • Patch Set #4, Line 90:

    /* Touch Host Controller Hid Over Spi Connection Speed
    	   Hid Over Spi Connection Speed - SPI Frequency
    	 */
    

    Ditto. (Also below.)

• File src/drivers/intel/touch/elan.h:

  • Patch Set #4, Line 16: // #define ELAN_CONNECTION_SPEED 17000000

    Why commented out?

• File src/drivers/intel/touch/touch.c:

  • Patch Set #4, Line 30: in rpt hdr addr

    Spell it out?

  • Patch Set #4, Line 65: "Use TH_SENSOR_GENERIC for parameters from the devicetree!\n");

    Indent more?

  • Patch Set #4, Line 106: printk(BIOS_INFO, "use WACOM Write Opcode\n");

    Why only the info message for the first case? What should the user do with this information?

  • Patch Set #4, Line 526:

    static void
    touch_generate_acpi_method_on(
    

    Why not one line?

  • Patch Set #4, Line 719:

    .read_resources   = pci_dev_read_resources,
    	.set_resources    = pci_dev_set_resources,
    	.enable_resources = pci_dev_enable_resources,
    	.init             = pci_dev_init,
    	.scan_bus         = &scan_generic_bus, /* Non-default */
    	.ops_pci          = &pci_dev_ops_pci,
    

    Use tabs for aligning = like below?

  • Patch Set #4, Line 743:

    Tab?

To view, visit change 81331. To unsubscribe, or for help writing mail filters, visit settings.