I went thru the GPIO listing and have a few questions, particular concerning the MGPIOs, SATA pins, and OC pins.
Some GPIOs listed don't seem to exist. It should be safe to set them as inputs as you have done, I just wanted to note them in case we're looking at different schematics/datasheets.
14 comments:
File src/mainboard/ocp/monolake/gpio.h:
Patch Set #1, Line 31: {9, GPIO_MODE_GPIO, GPIO_INPUT, 0, 0, 0},
GPIO9 and GPIO10 are overcurrent indicators, should they be left in native function (default) state?
Patch Set #1, Line 36: {14, GPIO_MODE_GPIO, GPIO_INPUT, 0, 0, 0},
GPIO14 is an overcurrent indicators, should it be left in native function (default) state?
Patch Set #1, Line 46: {24, GPIO_MODE_NATIVE, 0, 0, 0, 0},
I think this is acting as MGPIO0?
Patch Set #1, Line 50: {28, GPIO_MODE_NATIVE, 0, 0, 0, 0},
I think GPIO27 and GPIO28 are acting as MGPIO6 and MGPIO7?
Patch Set #1, Line 53: {31, GPIO_MODE_GPIO, GPIO_INPUT, 0, 0, 0},
I think this is acting as MGPIO2?
Patch Set #1, Line 56: {34, GPIO_MODE_GPIO, GPIO_INPUT, 0, 0, 0},
Oddly enough I don't even see GPIO34 mentioned in schematic, EDS, or other datasheets...
Anyway, it should be safe to set this as an input as you have done here. I'm just curious what, if anything, this should connect to.
Patch Set #1, Line 61: {39, GPIO_MODE_NATIVE, 0, 0, 0, 0},
Should SATA0GP (GPIO21) be set to native function as well?
Patch Set #1, Line 65: {43, GPIO_MODE_GPIO, GPIO_INPUT, 0, 0, 0},
GPIO40-43 are overcurrent indicators, should they be left in default (native function) state?
Patch Set #1, Line 69: {47, GPIO_MODE_GPIO, GPIO_INPUT, 0, 0, 0},
Same as GPIO34 - This pin doesn't seem to really exist... Should be safe to set it as an input in any case.
Patch Set #1, Line 78: {56, GPIO_MODE_GPIO, GPIO_INPUT, 0, 0, 0},
Another missing GPIO (like 47 and 34)?
Patch Set #1, Line 79: {57, GPIO_MODE_NATIVE, 0, 0, 0, 0},
I think this is acting as MGPIO5 (configured and driven by ME)?
Patch Set #1, Line 86: {64, GPIO_MODE_GPIO, GPIO_INPUT, 0, 0, 0},
GPIOs 63 and 64 don't seem to exist? (Should be safe to set as inputs as you are doing...)
Patch Set #1, Line 88: {66, GPIO_MODE_GPIO, GPIO_INPUT, 0, 0, 0},
Another missing one...
Patch Set #1, Line 95: {73, GPIO_MODE_GPIO, GPIO_INPUT, 0, 0, 0},
Another phantom GPIO...
To view, visit change 35367. To unsubscribe, or for help writing mail filters, visit settings.