Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30182 )
Change subject: IntelFB: Add support for Intel font driver ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30182/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30182/1//COMMIT_MSG@10 PS1, Line 10: Framebuffer during BIOS boot to display boot message/update messages. firmware boot
I don't see how it would be that useful. Please give a few more examples.
Graphics should be initialized at BS_DEV_INIT. After BS_DEV_INIT you only lock registers and write tables. Nothing that is expected to fail or generate that much verbose output. All the magic already has been done.
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/font8x16.c File src/drivers/intel/fb/font8x16.c:
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/font8x16.c@18 PS1, Line 18: * documentation and/or other materials provided with the distribution. is this license compatible to GPLv2 ? Please explain why you think so.