7 comments:
File src/soc/intel/common/block/cse/custom_bp.c:
Patch Set #12, Line 93: detected
are detected
Done
Patch Set #12, Line 543: /* Check if CSE reports data mismatch error */
That’s the description for the next function?
No, the comment is for cse_is_rw_dp_valid().
Patch Set #12, Line 556: triggers
trigger (to be in line with *issue*)
Done
Patch Set #12, Line 569: return false;
Add an error message with `die()`?
if this function fails, recovery mode is triggered in the error path.
Patch Set #12, Line 667: return false;
An error message should be returned here, saying that the downgrade is aborted.
Done
Patch Set #12, Line 729: /* If RW blob is present in CBFS, then trigger CSE firmware update */
Remove one space after tab?
Done
Patch Set #12, Line 731: uint8_t rv;
Unnecessary reordering in change.
Done
To view, visit change 40561. To unsubscribe, or for help writing mail filters, visit settings.