Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Shelley Chen, Tim Van Patten.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79737?usp=email )
Change subject: vendorcode/google/chromeos: API to read factory config
......................................................................
Patch Set 4:
(1 comment)
File src/vendorcode/google/chromeos/branding.c:
PS4:
nit: While we're currently getting the factory config to determine if CBX branding is enabled or not, the factory config value may contain other information in the future.
I suggest re-naming this file to `tpm_factory_config.c` (or something similar) to generalize things a bit more in case additional bits are added in the future un-related to CBX.
i like this suggetion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79737?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34f47c9a94972534cda656ef624ef12ed5ddeb06
Gerrit-Change-Number: 79737
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Comment-Date: Thu, 28 Dec 2023 03:37:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment