View Change
1 comment:
Commit Message:
Patch Set #1, Line 7: libpayload: Use typedef for OHCI enums
Why not simply delete the names?
I'd prefer to move the names where they belong (before the opening
brace). They still have a little documentary value, but we don't
really want to use them as types, as it seems.
To view, visit change 47224. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I452c0a1b118990942aa53f1e7e77f5e8378e8975
Gerrit-Change-Number: 47224
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber <jgarber1@ualberta.ca>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 05 Nov 2020 10:27:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment