Matt DeVillier has uploaded this change for review.

View Change

mb/google/reef: Fix guarding of reading SKU from VPD

VPD read depends on CONFIG(VPD), not CONFIG(CHROMEOS).

TEST=build/boot snappy, verify SKU set properly in SMBIOS

Change-Id: I8aa57f793bd04dbe31f3b49bbff23e05c96592a6
Signed-off-by: Matt DeVillier <>
M src/mainboard/google/reef/variants/snappy/mainboard.c
1 file changed, 15 insertions(+), 1 deletion(-)

git pull ssh:// refs/changes/53/68753/1
diff --git a/src/mainboard/google/reef/variants/snappy/mainboard.c b/src/mainboard/google/reef/variants/snappy/mainboard.c
index fc0652c..0b15505 100644
--- a/src/mainboard/google/reef/variants/snappy/mainboard.c
+++ b/src/mainboard/google/reef/variants/snappy/mainboard.c
@@ -43,7 +43,7 @@

board_sku_num = sku_strapping_value();

+ if (!CONFIG(VPD))
return board_sku_num;

if (!vpd_gets(vpd_skuid, vpd_buffer, ARRAY_SIZE(vpd_buffer), VPD_RO_THEN_RW))

To view, visit change 68753. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8aa57f793bd04dbe31f3b49bbff23e05c96592a6
Gerrit-Change-Number: 68753
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <>
Gerrit-MessageType: newchange