Thanks for the review
10 comments:
mb?
Done
File src/mainboard/kontron/mal10/acpi_tables.c:
This shouldn't be needed anymore
Removed
File src/mainboard/kontron/mal10/board_info.txt:
Patch Set #8, Line 7: Flashrom support: n
Not supported at all?
Sorry, I didn't notice
flash chip "W25Q128" (16384 kB, SPI)
Yes it is supported
fixed
File src/mainboard/kontron/mal10/dsdt.asl:
Patch Set #8, Line 29: /* CPU */
This comment does not add much value. […]
Done
Scope (\_SB) {
Device (PCI0)
Can use: […]
Done
Patch Set #8, Line 40: /* Chipset specific sleep states */
This comment was removed not too long ago
Done
File src/mainboard/kontron/mal10/gpio.h:
#if 0
PAD_CFG_NF_IOSSTATE(GPIO_196, NATIVE, DEEP, NF1, MASK), /* PNL1_VDDEN */
PAD_CFG_NF_IOSSTATE(GPIO_197, NATIVE, DEEP, NF1, MASK), /* PNL1_BKLTEN */
PAD_CFG_NF_IOSSTATE(GPIO_198, NATIVE, DEEP, NF1, MASK), /* PNL1_BKLTCTL */
why dead code?
Sorry, I forgot to delete this
lvds is currently disabled for this board
There is no device to test this interface
File src/mainboard/kontron/mal10/mainboard.c:
This seems to be dead code.
Yes you are right.
And since I don't use VGA_ROM_RUN, call install_intel_vga_int15_handler isn't needed.
https://github.com/coreboot/coreboot/blob/ef7a3267870f126cc2f815812cfe54500853d2b8/src/drivers/intel/gma/int15.h#L33
Removed
File src/mainboard/kontron/mal10/mal10.fmd:
Patch Set #8, Line 13: 0xb7d000
If you remove this size, the region will expand as much as possible. It helps to prevent gaps.
Done, thanks
File src/mainboard/kontron/mal10/variants/baseboard/devicetree.cb:
iGPU
Done
To view, visit change 39133. To unsubscribe, or for help writing mail filters, visit settings.