View Change
1 comment:
File src/lib/fmap.c:
Patch Set #2, Line 65: #endif
No, sorry, this shouldn't be in here. If we want to do this, it should be in rules.h. (I'd also consider calling it ENV_FIRST_C_STAGE instead.)
You are right. I just didn't want to add code there that's will likely be removed again in a week or two when romcc bootblocks are killed off.
To view, visit change 36908. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d70585b0c076707e73e20c2ed3f11e4c9ffdf37
Gerrit-Change-Number: 36908
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 22 Nov 2019 22:23:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: comment