Some minor changes requested. It looks good other than these that are mostly nits.
7 comments:
File src/soc/amd/picasso/Makefile.inc:
Could you put a comment on DEP_FILES explaining what it's doing?
# Add all the files listed in the config file
This applies to the other makefiles as well.
File src/southbridge/amd/pi/hudson/Kconfig:
Patch Set #65, Line 68: string "AMD PSP Firmware config file"
Remove this line and move the text to a help block? You don't need two 'string' entries and this doesn't need to be user-editable at this level. If a mainboard wants to use a different config, it can override it in the mainboard kconfig.
Patch Set #65, Line 69: if CPU_AMD_PI_00730F01
change this to a "depends on" statement so the option doesn't appear for other processors?
File src/southbridge/amd/pi/hudson/Makefile.inc:
#SMUFWM_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware$(FIRMWARE_TYPE).sbin
#SMUFWM_FN_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware$(FIRMWARE_TYPE)_FN.sbin
#SMUSCS_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuScs$(FIRMWARE_TYPE).bin
Why not remove these instead of commenting them out?
File util/amdfwtool/amdfwtool.c:
Patch Set #65, Line 222: /* static */
Is the comment supposed to be on a different line? This seems odd.
Patch Set #65, Line 599: /* For debugging */
nit: consider making this a separate commit?
remove D from the unused list?
To view, visit change 42859. To unsubscribe, or for help writing mail filters, visit settings.