Attention is currently required from: Anil Kumar K, Jérémy Compostella, Krishna P Bhat D, Paul Menzel, Subrata Banik, sridhar siricilla.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74577?usp=email )
Change subject: soc/intel/cse: Back up PSR data during CSE FW downgrade
......................................................................
Patch Set 52:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74577/comment/41186cfc_839246d7 :
PS50, Line 1125: An attempt to send PSR back-up command has been made.
something like "Back-up failed", is what i'm looking for record purposes. I just wanted to ensure there is a tracker in FW (CMOS or elogtool)to justify the PSR data loss. If google cloud missed the device telemetry then there has to some tracker to tell what might have happened which causes the data lose. Like a heart beat implementation where we would like to keep the last status (good or bad).
Yes, instead of adding a new CMOS state, we are creating an ELOG event in case of failures. That is in the subsequent patches.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74577?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I135d197b5df0a20def823fe615860b5ead4391f8
Gerrit-Change-Number: 74577
Gerrit-PatchSet: 52
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Thu, 28 Sep 2023 18:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Comment-In-Reply-To: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-MessageType: comment