Patch Set 3:

Patch Set 3:

1M is really a lot and wouldn't fit in most ramstages. Is that much heap really needed or should the linker scripts be adapted?

I'm confused by the "wouldn't fit" comment. Can you please explain under what conditions something won't fit?

If the heap is too large the ramstage can exceed the allotted size, resulting in an assertion error during the linking ("Ramstage exceeded its allotted size! (sz)" in memlayout.h). A lot of arm SOC have < 1M allotted for ramstage which prevents FDT support without increasing it or specifying a smaller heap size.

View Change

To view, visit change 32392. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id17f25e94d97e937b0e9a9cee3dd1a8aef1d525d
Gerrit-Change-Number: 32392
Gerrit-PatchSet: 3
Gerrit-Owner: Marty E. Plummer <hanetzer@startmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Marty E. Plummer <hanetzer@startmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 15 Sep 2019 21:03:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment