Nico Huber has posted comments on this change. (
Change subject: smbios: Add and adapt fields for version 3.2
Patch Set 5:
|> Still, you could fix the cpuid code first, then
add SMBIOS 3.2 stuff. I don't see why it would have to be part of the same commit.
Removing the new core/tread procedure here and keeping everything else, along with the
old core count in this commit would achieve the same goal, wouldn't it? If that is
your request please confirm and I will do just that.
You can do that. My only request is that you don't fix
existing fields and call that required for the SMBIOS
|> I was mostly referring to the added fields that were left untouched (at 0) where 0
isn't a valid value. Sorry for the confusion.
There are 3 added field which are set to 0, and 0 indeed is a valid value for each of
them. Please see these lines from the SMBIOS spec:
" A value of 0000h indicates the Memory Subsystem Controller Product ID is
" A value of 0000h indicates the Memory Subsystem Controller Manufacturer ID is
" A value of 0000h indicates the Module Product ID is unknown"
The FSP code have not yet been upgraded to 3.2 to popolate those memory fields
appropriately. Hence their "unknown" 0 values.
That's in the past, see above "I *was* mosly referring". You
fixed that already, I know.
To view, visit https://review.coreboot.org/c/coreboot/+/32090
To unsubscribe, or for help writing mail filters, visit
Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Francois Toguo Fotso
Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 17:42:34 +0000